qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/4] virtio-scsi: clean out duplicate cdb field


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 4/4] virtio-scsi: clean out duplicate cdb field
Date: Wed, 11 Mar 2015 15:03:10 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0


On 11/03/2015 14:43, Michael S. Tsirkin wrote:
>          struct {
>              VirtIOSCSICmdReq  cmd;
> -            uint8_t           cdb[];
>          } QEMU_PACKED;

Just:

    VirtIOSCSICmdReq cmd;

without the wrapping struct.

With this change series

Acked-by: Paolo Bonzini <address@hidden>

>          VirtIOSCSICtrlTMFReq  tmf;
>          VirtIOSCSICtrlANReq   an;
>      } req;
>  } VirtIOSCSIReq;
>  
> -QEMU_BUILD_BUG_ON(offsetof(VirtIOSCSIReq, req.cdb) !=
> -                  offsetof(VirtIOSCSIReq, req.cmd) + 
> sizeof(VirtIOSCSICmdReq));
> -



reply via email to

[Prev in Thread] Current Thread [Next in Thread]