qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 for-2.3 00/28] hw/pc: implement multiple prim


From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [PATCH v5 for-2.3 00/28] hw/pc: implement multiple primary busses for pc machines
Date: Wed, 11 Mar 2015 16:14:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 03/11/2015 04:12 PM, Gerd Hoffmann wrote:
On Di, 2015-03-10 at 17:31 +0200, Marcel Apfelbaum wrote:
v4->v5:
  - Rebased on pci branch, tree:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git
  - Added PXB documentation (patch 28/28)
  - Addressed Gerd Hoffmann's review:
    - fix PXB behaviour if used with unsupported BIOS (patch 27/28)
  - Addressed Michael S. Tsirkin's review:
    - Removed assert in aml_index (patch 5/28)
    - Renamed pci_ functions to crs_ (patch 12/28)
    - used uint64_t variables instead of signed ones (patch 12/28)
    - Emit MEM/IO AML only for PXBs and i440fx (patch 26/28)
  - Addressed Shannon Zhao's review:
    - Changed build_append_int to  build_append_byte in aml_or (patch
2/25)
  - Thanks to Igor and Kevin for reviews

Hi Gerd,

Tested-by: Gerd Hoffmann <address@hidden>
Appreciated!


Possible improvement:  When you figure the devices behind the pxb are
not initialized by the firmware (i.e. unmapped), you can try grab some
address space not used by devices under root bus 0 and assign it to the
pxb.  Then the linux kernel can initialize the devices even if the
firmware did not.


Thanks for the idea, it is on my todo list after I'll make hotplug work for PXB 
buses.
Marcel


[ Surely should be done incremental like hotplug support to not delay
   this series even more ]

cheers,
   Gerd






reply via email to

[Prev in Thread] Current Thread [Next in Thread]