[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] 9pfs-proxy: tiny cleanups in proxy_pwritev and
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-devel] [PATCH] 9pfs-proxy: tiny cleanups in proxy_pwritev and proxy_preadv |
|
Date: |
Thu, 12 Mar 2015 09:30:42 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0 |
10.03.2015 20:23, Aneesh Kumar K.V wrote:
[]>
> I am not sure this is needed, whether to use int err or int ret as the
> variable name is simply a matter of preference for the author.
We have 2 filesystem methods in here, read and write, one near another,
which are written by the same author (but one of them has been later
extended a bit, adding another variable). This patch makes them similar
again.
> Also did
> you compile test the above ? (note: int ret followed by a check with
> variable name 'err').
Well yes. It is a forgotten git commit. Ofcourse I verified the result,
I just forgot to commit because I was distracted by something else, hence
sent a wrong patch. I'll resend it.
/mjt