Re: [Qemu-devel] wrong size for virtio-scsi headers

[Michael S. Tsirkin]

On Thu, Mar 12, 2015 at 03:24:40AM +0000, Gonglei (Arei) wrote:
> Hi,
> 
> Today I start a vm failed, and get the following log:
> 
> qemu-system-x86_64: wrong size for virtio-scsi headers
> 
> 1) The Qemu command line:
> 
> ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name suse -device 
> virtio-scsi-pci,id=scsi0 -drive file=/home/suse11_sp3_32_2, \
> if=none,id=drive-scsi0-0-0-0,format=raw,cache=none,aio=native -device 
> scsi-hd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,\
> drive=drive-scsi0-0-0-0,id=scsi0-0-0-0  -vnc 0.0.0.0:10
> 
> 2) The backtrace:
> Breakpoint 1, virtio_scsi_bad_req () at /home/qemu/hw/scsi/virtio-scsi.c:91
> 91      {
> (gdb) bt
> #0  virtio_scsi_bad_req () at /home/qemu/hw/scsi/virtio-scsi.c:91
> #1  0x0000555555694ba9 in virtio_scsi_handle_cmd_req_prepare 
> (s=0x5555573767a0, req=0x5555571f22c0)
>     at /home/qemu/hw/scsi/virtio-scsi.c:531
> #2  0x0000555555694e22 in virtio_scsi_handle_cmd (vdev=0x5555573767a0, 
> vq=0x5555576a49f0) at /home/qemu/hw/scsi/virtio-scsi.c:583
> #3  0x00005555556aa2d9 in virtio_queue_notify_vq (vq=0x5555576a49f0) at 
> /home/qemu/hw/virtio/virtio.c:765
> #4  0x00005555556ac2cc in virtio_queue_host_notifier_read (n=0x5555576a4a40) 
> at /home/qemu/hw/virtio/virtio.c:1254
> #5  0x000055555596a276 in qemu_iohandler_poll (pollfds=0x555556336040, ret=1) 
> at iohandler.c:143
> #6  0x0000555555969e5b in main_loop_wait (nonblocking=0) at main-loop.c:495
> #7  0x000055555575c1e4 in main_loop () at vl.c:1795
> #8  0x0000555555763be1 in main (argc=50, argv=0x7fffffffdbe8, 
> envp=0x7fffffffdd80) at vl.c:4357
> 
> 3) Through git bisect fit with the below commit:
> 019adbd3715e98b5a09fab1370cc2c6904f79b6d is the first bad commit
> commit 019adbd3715e98b5a09fab1370cc2c6904f79b6d
> Author: Michael S. Tsirkin <address@hidden>
> Date:   Mon Feb 16 22:36:20 2015 +0100
> 
>     virtio-scsi: use standard-headers
>     
>     Drop duplicated code.
>     
>     Signed-off-by: Michael S. Tsirkin <address@hidden>
>     Acked-by: Paolo Bonzini <address@hidden>
> 
> :040000 040000 922bf75e013214104179c341054f872a873b2cad 
> 870458ed5e1ebd1284c502ee8457f0b7f8b5a23e M      hw
> :040000 040000 49e8fcb80e4a7ec6c64fb7c907f3232005bd1710 
> 994faf0a313f27cf07b0b50d7bbe2499ae7035a5 M      include
> 
> 4) Host:
>  Linux-3.0.93-0.8-default
> 
> Best regards,
> -Gonglei

Yes, I sent pull request fixing this.
Can you test pls?