[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset |
Date: |
Thu, 12 Mar 2015 10:21:47 +0000 |
On 12 March 2015 at 10:16, Michael S. Tsirkin <address@hidden> wrote:
> So thinking about this more, by the time kdump tries to reset device,
> linux has probably already disabled the IRQ at the APIC level.
> Isn't that the case? If so, the patch won't help, will it?
Trying to deassert (or worse, assert) interrupt lines in
device reset functions is slightly bogus, yes. In general
the theory is that the interrupt controller the interrupt line
is connected to should have its own reset handling which
treats the line as going back to deasserted, because there's
no guarantee made about which of the two ends of the line
gets its reset handler called first.
Things are not really this neat in practice though. (There's
no good way to model a device which comes out of reset with
a line asserted, for instance.)
-- PMM
- [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset, Fam Zheng, 2015/03/12
- Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset, Michael S. Tsirkin, 2015/03/12
- Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset, Michael S. Tsirkin, 2015/03/12
- Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset, Fam Zheng, 2015/03/12
- Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset, Michael S. Tsirkin, 2015/03/12
- Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset, Michael S. Tsirkin, 2015/03/12
- Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset, Michael S. Tsirkin, 2015/03/12
- Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset, Peter Maydell, 2015/03/12
- Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset, Michael S. Tsirkin, 2015/03/12
- Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset, Fam Zheng, 2015/03/13
- Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset, Fam Zheng, 2015/03/13
- Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset, Michael S. Tsirkin, 2015/03/16
- Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset, Michael S. Tsirkin, 2015/03/13