[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/5] monitor: Drop dead QMP check from monitor_read_
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 1/5] monitor: Drop dead QMP check from monitor_read_password() |
Date: |
Thu, 12 Mar 2015 17:26:46 +0100 |
Function is only called in HMP context since commit 333a96e "qapi:
Convert change".
Signed-off-by: Markus Armbruster <address@hidden>
---
monitor.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/monitor.c b/monitor.c
index c86a89e..29c930a 100644
--- a/monitor.c
+++ b/monitor.c
@@ -265,10 +265,7 @@ void monitor_read_command(Monitor *mon, int show_prompt)
int monitor_read_password(Monitor *mon, ReadLineFunc *readline_func,
void *opaque)
{
- if (monitor_ctrl_mode(mon)) {
- qerror_report(QERR_MISSING_PARAMETER, "password");
- return -EINVAL;
- } else if (mon->rs) {
+ if (mon->rs) {
readline_start(mon->rs, "Password: ", 1, readline_func, opaque);
/* prompt is printed on return from the command handler */
return 0;
--
1.9.3
- [Qemu-devel] [PATCH 0/5] monitor usb: Fixes for encrypted images, Markus Armbruster, 2015/03/12
- [Qemu-devel] [PATCH 2/5] monitor: Plug memory leak in monitor_read_bdrv_key_start(), Markus Armbruster, 2015/03/12
- [Qemu-devel] [PATCH 5/5] usb/dev-storage: Avoid qerror_report_err() outside QMP handlers, Markus Armbruster, 2015/03/12
- [Qemu-devel] [PATCH 4/5] usb/dev-storage: Fix QMP device_add missing encryption key failure, Markus Armbruster, 2015/03/12
- [Qemu-devel] [PATCH 1/5] monitor: Drop dead QMP check from monitor_read_password(),
Markus Armbruster <=
- [Qemu-devel] [PATCH 3/5] monitor usb: Inline monitor_read_bdrv_key_start()'s first part, Markus Armbruster, 2015/03/12
- Re: [Qemu-devel] [PATCH 0/5] monitor usb: Fixes for encrypted images, Eric Blake, 2015/03/12
- Re: [Qemu-devel] [PATCH 0/5] monitor usb: Fixes for encrypted images, Gerd Hoffmann, 2015/03/17