Re: [Qemu-devel] [PATCH v2 8/9] memory: Move owner-less MemoryRegions to /machine/unattached

[Andreas Färber]

Am 12.03.2015 um 19:05 schrieb Paolo Bonzini:
> On 12/03/2015 17:43, Andreas Färber wrote:
>> This cleans up the official /machine namespace. In particular
>> /machine/system and /machine/io as well as entries with non-sanitized
>> node names.
> 
> Just a question: isn't it /machine/system[0] and /machine/io[0]?

You're right. Still, now that these names are used in a global generic
context, I think "system" is too generic - "/machine/system-memory"
would be better than "/machine/system[0]".

Other names I referred to above are "vga ioports remapped[0]", "bochs
dispi interface[0]" and "qemu extended regs[0]", each containing spaces.
I.e., those names were at the time chosen as textual descriptions and
not as QOM path components.

>>
>> Cc: Paolo Bonzini <address@hidden>
>> Signed-off-by: Andreas Färber <address@hidden>
>> ---
>>  memory.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/memory.c b/memory.c
>> index 20f6d9e..ee3f2a8 100644
>> --- a/memory.c
>> +++ b/memory.c
>> @@ -868,7 +868,7 @@ void memory_region_init(MemoryRegion *mr,
>>                          uint64_t size)
>>  {
>>      if (!owner) {
>> -        owner = qdev_get_machine();
>> +        owner = container_get(qdev_get_machine(), "/unattached");
>>      }
>>  
>>      object_initialize(mr, sizeof(*mr), TYPE_MEMORY_REGION);
>>
> 
> Acked-by: Paolo Bonzini <address@hidden>

Do you have any outstanding memory patches, or should I fix up the
commit message and take it through qom-next?

Thanks,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)