[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 for-2.3 0/4] Convert 'status' of MigrationInfo fr
From: |
zhanghailiang |
Subject: |
[Qemu-devel] [PATCH v5 for-2.3 0/4] Convert 'status' of MigrationInfo from open-coded 'str' to enum type |
Date: |
Fri, 13 Mar 2015 16:08:37 +0800 |
Hi Juan & Amit,
This series has been reviewed, and could you help merging them ?
Thanks,
zhanghailiang
This series converts open-coded 'str' type to enum type for 'status'.
This conversion will be more convenient for future extensibility.
Actually, I will add a MIG_STATE_COLO state for COLO, and i also
saw Dave added MIG_STATE_POSTCOPY_ACTIVE for postcopy.
Patch 1 and 2 are preparation for the conversion, patch 3 completes the
conversion.
Besides, i add a additional patch (patch 4) to expose 'cancelling' to user,
it will influence libvirt side. And i have CC libvirt development.
One more thing, i have to replace MIG_STATE_ERROR with MIGRATION_STATUS_FAILED,
and it begin from 0, not its original -1. I think it has no side effect.
Please review.
v5:
- Move 'failed' to the behind of 'completed'
- s/MigState/MigrationStatus/ (Eric)
- Add Reviewd-by for patch 1 and 3
v4:
- Rename _ERROR to _FAILED in patch 1 instead of patch 4 (Eric)
- Add Reviewd-by for patch 2 and 4
- Fix some grammar in commit message of patch 4 (Eric)
v3:
- Use longer name for Migration status macro. (Eric Blake)
- Rename internal-only typename 'MigrationStatus' (Eric, Dave, Markus)
- Expose 'cancelling' state (Eric Blake)
v2:
- Remove '(since xyz)' strings. (Eric Blake)
Thanks for their comments. ;)
zhanghailiang (4):
migration: Rename abbreviated macro MIG_STATE_* to
MIGRATION_STATUS_*
hmp: Rename 'MigrationStatus' to 'HMPMigrationStatus'
migration: Convert 'status' of MigrationInfo to use an enum type
migration: Expose 'cancelling' status to user
hmp.c | 15 ++++----
migration/migration.c | 95 ++++++++++++++++++++++++---------------------------
qapi-schema.json | 34 +++++++++++++++---
3 files changed, 81 insertions(+), 63 deletions(-)
--
1.7.12.4
- [Qemu-devel] [PATCH v5 for-2.3 0/4] Convert 'status' of MigrationInfo from open-coded 'str' to enum type,
zhanghailiang <=
- [Qemu-devel] [PATCH v5 for-2.3 2/4] hmp: Rename 'MigrationStatus' to 'HMPMigrationStatus', zhanghailiang, 2015/03/13
- [Qemu-devel] [PATCH v5 for-2.3 1/4] migration: Rename abbreviated macro MIG_STATE_* to MIGRATION_STATUS_*, zhanghailiang, 2015/03/13
- [Qemu-devel] [PATCH v5 for-2.3 4/4] migration: Expose 'cancelling' status to user, zhanghailiang, 2015/03/13
- [Qemu-devel] [PATCH v5 for-2.3 3/4] migration: Convert 'status' of MigrationInfo to use an enum type, zhanghailiang, 2015/03/13
- Re: [Qemu-devel] [PATCH v5 for-2.3 0/4] Convert 'status' of MigrationInfo from open-coded 'str' to enum type, Juan Quintela, 2015/03/17