Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

[Paolo Bonzini]

On 16/03/2015 15:45, Eric Blake wrote:
> On 03/16/2015 04:31 AM, address@hidden wrote:
>> From: Claudio Fontana <address@hidden>
>> 
>> usage is similar to the commands x, xp.
>> 
>> Example with string: looking for "ELF" header in memory:
>> 
>> (qemu) s/1000000cb 0x40001000 "ELF" searching memory area
>> [0000000040001000-00000000400f5240] 0000000040090001 (qemu) x/20b
>> 0x40090000 0000000040090000: '\x7f' 'E' 'L' 'F' '\x02' '\x01'
>> '\x01' '\x03' 0000000040090008: '\x00' '\x00' '\x00' '\x00'
>> '\x00' '\x00' '\x00' '\x00' 0000000040090010: '\x02' '\x00'
>> '\xb7' '\x00'
>> 
>> Example with value: looking for 64bit variable value 0x990088
>> 
>> (qemu) s/1000000xg 0xffff900042000000 0x990088 searching memory
>> area [ffff900042000000-ffff9000427a1200] ffff9000424b3000 
>> ffff9000424c1000
>> 
>> Signed-off-by: Claudio Fontana <address@hidden> --- 
>> hmp-commands.hx |  28 ++++++++++++ monitor.c       | 140
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files
>> changed, 168 insertions(+)
>> 
>> Hello, looking for some comments on whether the addition of this 
>> command is welcome, and whether the syntax chosen is acceptable, 
>> or how it can made better.
> 
> Do you want to provide a QMP counterpart?  In general, we are
> reluctant to add new HMP functionality that cannot also be accessed
> via QMP.

I think this is okay for a debugging command.  x and xp do not have an
QMP equivalent either.

Paolo