Re: [Qemu-devel] [PATCH v2 0/9] qom: HMP commands to supersede info qtree

[Alistair Francis]

On Fri, Mar 13, 2015 at 11:30 AM, Gonglei <address@hidden> wrote:
> On 2015/3/13 0:43, Andreas Färber wrote:
>> Hello,
>>
>> The main patch of this series is an HMP command "info qom-tree",
>> which displays the machine composition tree. This names all objects,
>> including those missing in "info qtree" for lack of bus or for not being a 
>> device.
>>
>> Properties can be listed with "qom-list" and set with "qom-set", like in QMP.
>>
>> "qom-get" and displaying properties as part of "info qom-tree" ran into
>> StringOutputVisitor limitations - this v2 therefore stubs that support out
>> so that we don't crash.
>>
>> This series has been around for a year now; I hope to get at least qom-list 
>> and
>> the basic info qom-tree into v2.3, as visualization of my upcoming CPU 
>> changes.
>>
> I have been looking forward to these HMP commands are merged. ;)
>
> They are coming now...

This is great!

Unfortunately I don't understand it enough to sign off on anything,
but it looks good.
I did do some testing on some pretty big machines and it seems to work well.

Tested-by: Alistair Francis <address@hidden>

Thanks,

Alistair

>
> Regards,
> -Gonglei
>> Also included are two proposed cleanups of nodes in /machine namespace.
>> By making it easier to inspect the tree, I hope we'll detect this earlier.
>>
>> Regards,
>> Andreas
>
>
>