|
| From: | Peter Maydell |
| Subject: | Re: [Qemu-devel] [PATCH 2/7] Convert (ffs(val) - 1) to ctz32(val) |
| Date: | Tue, 17 Mar 2015 12:09:22 +0000 |
On 17 March 2015 at 11:56, Stefan Hajnoczi <address@hidden> wrote: > This commit was generated mechanically by coccinelle from the following > semantic patch: > > @@ > expression val; > @@ > - (ffs(val) - 1) > + ctz32(val) Did you check all these callsites to make sure that the value passed in can never be zero? (ffs(0) - 1) is -1 whereas ctz32(0) is 32... -- PMM
| [Prev in Thread] | Current Thread | [Next in Thread] |