[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 2/9] hw/arm/nseries: convert ffs(3) to ctz32()
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH v2 2/9] hw/arm/nseries: convert ffs(3) to ctz32() |
Date: |
Tue, 17 Mar 2015 15:09:40 +0000 |
It is not clear from the code how a 0 parameter should be handled by the
hardware. Keep the same behavior as ffs(0) - 1 == -1.
Cc: Andrzej Zaborowski <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/arm/nseries.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
index 4d7be5e..606941a 100644
--- a/hw/arm/nseries.c
+++ b/hw/arm/nseries.c
@@ -579,7 +579,10 @@ static uint32_t mipid_txrx(void *opaque, uint32_t cmd, int
len)
case 0x26: /* GAMSET */
if (!s->pm) {
- s->gamma = ffs(s->param[0] & 0xf) - 1;
+ s->gamma = ctz32(s->param[0] & 0xf);
+ if (s->gamma == 32) {
+ s->gamma = -1; /* XXX: should this be 0? */
+ }
} else if (s->pm < 0) {
s->pm = 1;
}
--
2.1.0
- [Qemu-devel] [PATCH v2 0/9] Convert ffs(3) to ctz32(), Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH v2 1/9] bt-sdp: fix broken uuids power-of-2 calculation, Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH v2 4/9] Convert (ffs(val) - 1) to ctz32(val), Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH v2 3/9] uninorth: convert ffs(3) to ctz32(), Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH v2 6/9] sd: convert sd_normal_command() ffs(3) call to ctz32(), Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH v2 2/9] hw/arm/nseries: convert ffs(3) to ctz32(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v2 7/9] omap_intc: convert ffs(3) to ctz32() in omap_inth_sir_update(), Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH v2 5/9] Convert ffs() != 0 callers to ctz32(), Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH v2 8/9] os-win32: drop ffs(3) prototype, Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH v2 9/9] checkpatch: complain about ffs(3) calls, Stefan Hajnoczi, 2015/03/17