[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH target-arm v3 15/15] arm: xlnx-zynqmp: Add PSCI
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [PATCH target-arm v3 15/15] arm: xlnx-zynqmp: Add PSCI setup |
Date: |
Wed, 18 Mar 2015 15:06:34 +1000 |
On Mon, Mar 16, 2015 at 10:12 PM, Peter Crosthwaite
<address@hidden> wrote:
> Use SMC PSCI, with the standard policy of secondaries starting in
> power-off.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
Looks good,
Reviewed-by: Alistair Francis <address@hidden>
Thanks,
Alistair
> ---
> changed since v1:
> Add &error_abort to property setter calls
>
> hw/arm/xlnx-zynqmp.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
> index e015025..0265fba 100644
> --- a/hw/arm/xlnx-zynqmp.c
> +++ b/hw/arm/xlnx-zynqmp.c
> @@ -97,6 +97,14 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error
> **errp)
> for (i = 0; i < XLNX_ZYNQMP_NUM_CPUS; i++) {
> qemu_irq irq;
>
> + object_property_set_int(OBJECT(&s->cpu[i]), QEMU_PSCI_CONDUIT_SMC,
> + "psci-conduit", &error_abort);
> + if (i > 0) {
> + /* Secondary CPUs start in PSCI powered-down state */
> + object_property_set_bool(OBJECT(&s->cpu[i]), true,
> + "start-powered-off", &error_abort);
> + }
> +
> object_property_set_bool(OBJECT(&s->cpu[i]), true, "realized", &err);
> ERR_PROP_CHECK_RETURN(err, errp);
>
> --
> 2.3.1.2.g90df61e.dirty
>
>
- [Qemu-devel] [PATCH target-arm v3 02/15] target-arm: cpu64: Add support for cortex-a53, (continued)
- [Qemu-devel] [PATCH target-arm v3 02/15] target-arm: cpu64: Add support for cortex-a53, Peter Crosthwaite, 2015/03/16
- [Qemu-devel] [PATCH target-arm v3 03/15] arm: Introduce Xilinx ZynqMP SoC, Peter Crosthwaite, 2015/03/16
- [Qemu-devel] [PATCH target-arm v3 01/15] target-arm: cpu64: Factor out ARM cortex init, Peter Crosthwaite, 2015/03/16
- [Qemu-devel] [PATCH target-arm v3 13/15] arm: xilinx-ep108: Add external RAM, Peter Crosthwaite, 2015/03/16
- [Qemu-devel] [PATCH target-arm v3 06/15] net: cadence_gem: Clean up variable names, Peter Crosthwaite, 2015/03/16
- [Qemu-devel] [PATCH target-arm v3 10/15] char: cadence_uart: Split state struct and type into header, Peter Crosthwaite, 2015/03/16
- [Qemu-devel] [PATCH target-arm v3 09/15] char: cadence_uart: Clean up variable names, Peter Crosthwaite, 2015/03/16
- [Qemu-devel] [PATCH target-arm v3 12/15] arm: Add xlnx-ep108 machine, Peter Crosthwaite, 2015/03/16
- [Qemu-devel] [PATCH target-arm v3 15/15] arm: xlnx-zynqmp: Add PSCI setup, Peter Crosthwaite, 2015/03/16
- Re: [Qemu-devel] [PATCH target-arm v3 15/15] arm: xlnx-zynqmp: Add PSCI setup,
Alistair Francis <=