[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/3] uhci: fix segfault when hot-unplugging u
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/3] uhci: fix segfault when hot-unplugging uhci controller |
Date: |
Wed, 18 Mar 2015 08:02:39 +0100 |
Hi,
> -static void uhci_reset(void *opaque)
> +static void uhci_reset(DeviceState *dev)
> {
> - UHCIState *s = opaque;
> + PCIDevice *d = PCI_DEVICE(dev);
> + UHCIState *s = DO_UPCAST(UHCIState, dev, d);
Uh, oh, DO_UPCAST() is long deprecated. There are other instances of
this in the uhci emulation though, so we need a cleanup & qom-ify pass
for the code anyway. So I think it's ok for a bugfix patch.
I'll queue it up (and the other two too of course).
cheers,
Gerd