[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 4/7] pcie_aer: expose pcie_aer_msg() interfac
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v5 4/7] pcie_aer: expose pcie_aer_msg() interface |
Date: |
Wed, 18 Mar 2015 14:29:58 +0100 |
On Thu, Mar 12, 2015 at 06:23:56PM +0800, Chen Fan wrote:
> For vfio device, we need to propagate the aer error to
> Guest OS. we use the pcie_aer_msg() to send aer error
> to guest.
>
> Signed-off-by: Chen Fan <address@hidden>
Interesting.
pcie_aer_inject_error was intended as an interface to
send errors to guest.
For example, pcie_aer_msg does not handle the log at all.
Why do you use the lower-level pcie_aer_msg?
> ---
> hw/pci/pcie_aer.c | 2 +-
> include/hw/pci/pcie_aer.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c
> index 71045eb..f2d5d13 100644
> --- a/hw/pci/pcie_aer.c
> +++ b/hw/pci/pcie_aer.c
> @@ -370,7 +370,7 @@ static void pcie_aer_msg_root_port(PCIDevice *dev, const
> PCIEAERMsg *msg)
> *
> * Walk up the bus tree from the device, propagate the error message.
> */
> -static void pcie_aer_msg(PCIDevice *dev, const PCIEAERMsg *msg)
> +void pcie_aer_msg(PCIDevice *dev, const PCIEAERMsg *msg)
> {
> uint8_t type;
>
> diff --git a/include/hw/pci/pcie_aer.h b/include/hw/pci/pcie_aer.h
> index a4cc6f3..80cba7b 100644
> --- a/include/hw/pci/pcie_aer.h
> +++ b/include/hw/pci/pcie_aer.h
> @@ -102,5 +102,6 @@ void pcie_aer_root_write_config(PCIDevice *dev,
>
> /* error injection */
> int pcie_aer_inject_error(PCIDevice *dev, const PCIEAERErr *err);
> +void pcie_aer_msg(PCIDevice *dev, const PCIEAERMsg *msg);
>
> #endif /* QEMU_PCIE_AER_H */
> --
> 1.9.3
>
[Qemu-devel] [PATCH v5 1/7] vfio: add pcie extanded capability support, Chen Fan, 2015/03/12
[Qemu-devel] [PATCH v5 4/7] pcie_aer: expose pcie_aer_msg() interface, Chen Fan, 2015/03/12
[Qemu-devel] [PATCH v5 2/7] aer: impove pcie_aer_init to support vfio device, Chen Fan, 2015/03/12
[Qemu-devel] [PATCH v5 3/7] vfio: add aer support for vfio device, Chen Fan, 2015/03/12
[Qemu-devel] [PATCH v5 6/7] vfio: add 'x-aer' property to expose aercap, Chen Fan, 2015/03/12
[Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device, Chen Fan, 2015/03/12