[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/8] exec: mark unassigned_io_ops as unlocked
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 6/8] exec: mark unassigned_io_ops as unlocked |
Date: |
Wed, 18 Mar 2015 15:53:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 18/03/2015 15:33, Jan Kiszka wrote:
> On 2015-03-18 14:21, Paolo Bonzini wrote:
>> Signed-off-by: Paolo Bonzini <address@hidden>
>
> A commit log should briefly state why we can do this safely (no state
> dependency, no need for locking). Yes, it's trivial in this case but
> already a little bit less trivial in case of the PM timer.
Guilty as charged...
Paolo
>> ---
>> exec.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/exec.c b/exec.c
>> index d60abfc..c1a2e9e 100644
>> --- a/exec.c
>> +++ b/exec.c
>> @@ -2197,6 +2197,7 @@ static void memory_map_init(void)
>> system_io = g_malloc(sizeof(*system_io));
>> memory_region_init_io(system_io, NULL, &unassigned_io_ops, NULL, "io",
>> 65536);
>> + memory_region_clear_global_locking(system_io);
>> address_space_init(&address_space_io, system_io, "I/O");
>>
>> memory_listener_register(&core_memory_listener, &address_space_memory);
>>
>
> Jan
>
- [Qemu-devel] [PATCH for-2.4 0/8] memory: enable unlocked PIO/MMIO in KVM, Paolo Bonzini, 2015/03/18
- [Qemu-devel] [PATCH 1/8] memory: Add global-locking property to memory regions, Paolo Bonzini, 2015/03/18
- [Qemu-devel] [PATCH 3/8] memory: Provide address_space_rw_unlocked, Paolo Bonzini, 2015/03/18
- [Qemu-devel] [PATCH 2/8] exec: move rcu_read_lock/unlock to address_space_translate callers, Paolo Bonzini, 2015/03/18
- [Qemu-devel] [PATCH 4/8] kvm: First step to push iothread lock out of inner run loop, Paolo Bonzini, 2015/03/18
- [Qemu-devel] [PATCH 6/8] exec: mark unassigned_io_ops as unlocked, Paolo Bonzini, 2015/03/18
- [Qemu-devel] [PATCH 7/8] acpi: mark PMTIMER as unlocked, Paolo Bonzini, 2015/03/18
- [Qemu-devel] [PATCH 5/8] kvm: Switch to unlocked PIO, Paolo Bonzini, 2015/03/18
- [Qemu-devel] [PATCH 8/8] kvm: Switch to unlocked MMIO, Paolo Bonzini, 2015/03/18
- Re: [Qemu-devel] [PATCH for-2.4 0/8] memory: enable unlocked PIO/MMIO in KVM, Jan Kiszka, 2015/03/18