[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 18/24] vl: fix resource leak with monitor_fdset_add_f
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 18/24] vl: fix resource leak with monitor_fdset_add_fd |
Date: |
Thu, 19 Mar 2015 12:05:36 +0300 |
From: Paolo Bonzini <address@hidden>
monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP
command add_fd). Free it.
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
vl.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 694deb4..69617d6 100644
--- a/vl.c
+++ b/vl.c
@@ -1012,6 +1012,7 @@ static int parse_add_fd(QemuOpts *opts, void *opaque)
int fd, dupfd, flags;
int64_t fdset_id;
const char *fd_opaque = NULL;
+ AddfdInfo *fdinfo;
fd = qemu_opt_get_number(opts, "fd", -1);
fdset_id = qemu_opt_get_number(opts, "set", -1);
@@ -1061,8 +1062,9 @@ static int parse_add_fd(QemuOpts *opts, void *opaque)
}
/* add the duplicate fd, and optionally the opaque string, to the fd set */
- monitor_fdset_add_fd(dupfd, true, fdset_id, fd_opaque ? true : false,
- fd_opaque, NULL);
+ fdinfo = monitor_fdset_add_fd(dupfd, true, fdset_id, !!fd_opaque,
fd_opaque,
+ &error_abort);
+ g_free(fdinfo);
return 0;
}
--
2.1.4
- [Qemu-devel] [PULL 00/24] Trivial patches for 2015-03-19, Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 07/24] qom: Fix warning from Sparse, Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 15/24] configure: enable kvm on x32, Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 16/24] pc-dimm: Add description for device list., Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 09/24] block/qapi: Fix Sparse warning, Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 21/24] hmp: Fix texinfo documentation, Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 14/24] error: Replace error_report() & error_free() with error_report_err(), Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 03/24] 9pfs: Fix warnings from Sparse, Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 18/24] vl: fix resource leak with monitor_fdset_add_fd,
Michael Tokarev <=
- [Qemu-devel] [PULL 24/24] qga/commands-posix: Fix resource leak, Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 20/24] Fix typos in comments, Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 12/24] qmp: Drop unused .user_print from command definitions, Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 08/24] Fix remaining warnings from Sparse (void return), Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 06/24] target-mips: Fix warning from Sparse, Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 01/24] cris: remove unused cris_cond15 declarations, Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 10/24] target-moxie: Fix warnings from Sparse (one-bit signed bitfield), Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 19/24] qtest/ahci: Fix a bit mask expression, Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 05/24] arm/nseries: Fix warnings from Sparse, Michael Tokarev, 2015/03/19
- [Qemu-devel] [PULL 22/24] elf-loader: Fix truncation warning from coverity, Michael Tokarev, 2015/03/19