Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class

[Michael S. Tsirkin]

On Thu, Mar 19, 2015 at 12:33:01PM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > > Adding not-yet upstream files to the list of headers to sync over from
> > > linux isn't sane IMHO.
> > > 
> > > cheers,
> > >   Gerd
> > > 
> > 
> > Of course it isn't. But you can sync it manually. Once it's upstream,
> > add it to list for automated sync.
> 
> Hmm, well, not that simple, there is no whitelist for virtio headers but
> a "*virtio*.h" glob.  So it'll simply sync automatic once landed
> upstream, and may get deleted by accident before.

Well no - by design we only update headers, never delete them.
If someone does manage to delete a header it's just a question of running
make before pushing upstream, isn't it?

> I've sent the guest kernel driver meanwhile, maybe this goes in quickly
> and and renders the whole discussion moot ;)
> 
> cheers,
>   Gerd
>