[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386: remove superfluous TARGET_HAS_SMC
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] target-i386: remove superfluous TARGET_HAS_SMC macro |
Date: |
Sat, 21 Mar 2015 19:45:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 21/03/2015 18:29, Emilio G. Cota wrote:
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> target-i386/cpu.h | 2 --
> translate-all.c | 4 ----
> 2 files changed, 6 deletions(-)
>
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 15db6d7..4ee12ca 100644
> --- a/target-i386/cpu.h
> +++ b/target-i386/cpu.h
> @@ -31,8 +31,6 @@
> /* Maximum instruction code size */
> #define TARGET_MAX_INSN_SIZE 16
>
> -/* target supports implicit self modifying code */
> -#define TARGET_HAS_SMC
> /* support for self modifying code even if the modified instruction is
> close to the modifying instruction */
> #define TARGET_HAS_PRECISE_SMC
> diff --git a/translate-all.c b/translate-all.c
> index 9f47ce7..11763c6 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -1334,8 +1334,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
> p->first_tb = (TranslationBlock *)((uintptr_t)tb | n);
> invalidate_page_bitmap(p);
>
> -#if defined(TARGET_HAS_SMC) || 1
> -
> #if defined(CONFIG_USER_ONLY)
> if (p->flags & PAGE_WRITE) {
> target_ulong addr;
> @@ -1371,8 +1369,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
> tlb_protect_code(page_addr);
> }
> #endif
> -
> -#endif /* TARGET_HAS_SMC */
> }
>
> /* add a new TB and link it to the physical page tables. phys_page2 is
>
Reviewed-by: Paolo Bonzini <address@hidden>