[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [RFC PATCH COLO v2 01/13] docs: block repl
From: |
Gonglei |
Subject: |
Re: [Qemu-devel] [Qemu-block] [RFC PATCH COLO v2 01/13] docs: block replication's description |
Date: |
Thu, 26 Mar 2015 18:28:45 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 2015/3/26 16:58, Wen Congyang wrote:
> On 03/25/2015 11:38 PM, Eric Blake wrote:
>> > On 03/25/2015 03:36 AM, Wen Congyang wrote:
>>> >> Signed-off-by: Wen Congyang <address@hidden>
>>> >> Signed-off-by: Paolo Bonzini <address@hidden>
>>> >> Signed-off-by: Yang Hongyang <address@hidden>
>>> >> Signed-off-by: zhanghailiang <address@hidden>
>>> >> Signed-off-by: Gonglei <address@hidden>
>>> >> ---
>>> >> docs/block-replication.txt | 147
>>> >> +++++++++++++++++++++++++++++++++++++++++++++
>>> >> 1 file changed, 147 insertions(+)
>>> >> create mode 100644 docs/block-replication.txt
>>> >>
>> >
>> > Grammar review only (I'll leave the technical review to others)
>> >
>>> >> diff --git a/docs/block-replication.txt b/docs/block-replication.txt
>>> >> new file mode 100644
>>> >> index 0000000..874ed8e
>>> >> --- /dev/null
>>> >> +++ b/docs/block-replication.txt
>>> >> @@ -0,0 +1,147 @@
>>> >> +Block replication
>>> >> +----------------------------------------
>>> >> +Copyright Fujitsu, Corp. 2015
>>> >> +Copyright (c) 2015 Intel Corporation
>>> >> +Copyright (c) 2015 HUAWEI TECHNOLOGIES CO.,LTD.
>> >
>> > Space after comma in English writing.
> Yes, but I am not sure I can change it. HUAWEI always use this way.
> You can find it in bootdevice.c
Good catch, Eric is right. I will change all of this writing way in Qemu at 2.4.
Thanks.
Regards,
-Gonglei
Re: [Qemu-devel] [RFC PATCH COLO v2 01/13] docs: block replication's description, Fam Zheng, 2015/03/26
[Qemu-devel] [RFC PATCH COLO v2 02/13] quorum: allow ignoring child errors, Wen Congyang, 2015/03/25
[Qemu-devel] [RFC PATCH COLO v2 03/13] NBD client: connect to nbd server later, Wen Congyang, 2015/03/25
[Qemu-devel] [RFC PATCH COLO v2 06/13] NBD client: implement block driver interfaces for block replication, Wen Congyang, 2015/03/25