[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/22] ui/console: check memory_region_is_logging
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 07/22] ui/console: check memory_region_is_logging |
Date: |
Thu, 26 Mar 2015 18:38:25 +0100 |
dpy_gfx_update_dirty expects DIRTY_MEMORY_VGA logging to be always on,
but that will not be the case soon. Because it computes the memory
region on the fly for every update (with memory_region_find), it cannot
enable/disable logging by itself.
Instead, always treat updates as invalidations if dirty logging is
not enabled, assuming that the board will enable logging on the
RAM region that includes the framebuffer.
To simplify the code, replace memory_region_get_dirty with
memory_region_test_and_clear_dirty. Then memory_region_reset_dirty
is only needed in the invalidate case.
Signed-off-by: Paolo Bonzini <address@hidden>
---
ui/console.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/ui/console.c b/ui/console.c
index b15ca87..2241b32 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -1627,14 +1627,22 @@ void dpy_gfx_update_dirty(QemuConsole *con,
}
assert(mem);
- memory_region_sync_dirty_bitmap(mem);
+ if (memory_region_is_logging(mem)) {
+ memory_region_sync_dirty_bitmap(mem);
+ if (invalidate) {
+ memory_region_reset_dirty(mem, mem_section.offset_within_region,
size,
+ DIRTY_MEMORY_VGA);
+ }
+ } else {
+ invalidate = true;
+ }
addr = mem_section.offset_within_region;
first = -1;
last = -1;
for (i = 0; i < height; i++, addr += width) {
dirty = invalidate ||
- memory_region_get_dirty(mem, addr, width, DIRTY_MEMORY_VGA);
+ memory_region_test_and_clear_dirty(mem, addr, width,
DIRTY_MEMORY_VGA);
if (dirty) {
if (first == -1) {
first = i;
@@ -1654,8 +1662,6 @@ void dpy_gfx_update_dirty(QemuConsole *con,
last - first + 1);
}
- memory_region_reset_dirty(mem, mem_section.offset_within_region, size,
- DIRTY_MEMORY_VGA);
out:
memory_region_unref(mem);
}
--
2.3.3
- [Qemu-devel] [PATCH 00/22] Dirty bitmap atomic access and optimizations, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 01/22] memory: add memory_region_ram_resize, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 02/22] acpi-build: remove dependency from ram_addr.h, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 03/22] memory: the only dirty memory flag for users is DIRTY_MEMORY_VGA, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 07/22] ui/console: check memory_region_is_logging,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 05/22] memory: return bitmap from memory_region_is_logging, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 09/22] memory: return DIRTY_MEMORY_MIGRATION from memory_region_is_logging, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 12/22] exec: use memory_region_is_logging to optimize dirty tracking, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 06/22] framebuffer: check memory_region_is_logging, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 10/22] ram_addr: tweaks to xen_modified_memory, Paolo Bonzini, 2015/03/26