[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-2.3 1/6] sb16: remove useless mixer_write_indexw
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH for-2.3 1/6] sb16: remove useless mixer_write_indexw |
Date: |
Mon, 30 Mar 2015 13:45:13 +0200 |
ioport.c is already able to split a 16-bit access into two 8-bit
accesses to consecutive ports. Tested with Epic Pinball.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/audio/sb16.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c
index 444eb9e..b052de5 100644
--- a/hw/audio/sb16.c
+++ b/hw/audio/sb16.c
@@ -1121,12 +1121,6 @@ static IO_WRITE_PROTO (mixer_write_datab)
s->mixer_regs[s->mixer_nreg] = val;
}
-static IO_WRITE_PROTO (mixer_write_indexw)
-{
- mixer_write_indexb (opaque, nport, val & 0xff);
- mixer_write_datab (opaque, nport, (val >> 8) & 0xff);
-}
-
static IO_READ_PROTO (mixer_read)
{
SB16State *s = opaque;
@@ -1345,7 +1339,6 @@ static const VMStateDescription vmstate_sb16 = {
static const MemoryRegionPortio sb16_ioport_list[] = {
{ 4, 1, 1, .write = mixer_write_indexb },
- { 4, 1, 2, .write = mixer_write_indexw },
{ 5, 1, 1, .read = mixer_read, .write = mixer_write_datab },
{ 6, 1, 1, .read = dsp_read, .write = dsp_write },
{ 10, 1, 1, .read = dsp_read },
--
2.3.4
- [Qemu-devel] [PATCH for-2.3 0/3] ioport fixes, Paolo Bonzini, 2015/03/30
- [Qemu-devel] [PATCH for-2.3 3/6] ide: there is only one data port, Paolo Bonzini, 2015/03/30
- [Qemu-devel] [PATCH for-2.3 2/6] gus: clean up MemoryRegionPortio, Paolo Bonzini, 2015/03/30
- [Qemu-devel] [PATCH for-2.3 4/6] ioport: remove wrong comment, Paolo Bonzini, 2015/03/30
- [Qemu-devel] [PATCH for-2.3 1/6] sb16: remove useless mixer_write_indexw,
Paolo Bonzini <=
- [Qemu-devel] [PATCH for-2.3 5/6] ioport: loosen assertions on emulation of 16-bit ports, Paolo Bonzini, 2015/03/30
- [Qemu-devel] [PATCH for-2.3 6/6] ioport: reserve the whole range of an I/O port in the AddressSpace, Paolo Bonzini, 2015/03/30
- Re: [Qemu-devel] [PATCH for-2.3 0/3] ioport fixes, Mark Cave-Ayland, 2015/03/31