Re: [Qemu-devel] [PATCH for-2.3] pc: acpi: fix pvpanic regression

[Igor Mammedov]

On Mon, 30 Mar 2015 14:27:05 +0200
Paolo Bonzini <address@hidden> wrote:

> 
> 
> On 30/03/2015 14:18, Igor Mammedov wrote:
> > Commit cd61cb2  pc: acpi-build: generate pvpanic device description 
> > dynamically
> > 
> > introduced regression changing pvpanic device HID from
> > QEMU0001 to QEMU0002.
> > Fix AML generated code so that pvpanic device
> > would keep its original HID. i.e. QEMU0001
> > 
> > Signed-off-by: Igor Mammedov <address@hidden>
> > Reported-by: Gal Hammer <address@hidden>
> > ---
> >  hw/i386/acpi-build.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index d0a5c85..e761005 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -788,7 +788,7 @@ build_ssdt(GArray *table_data, GArray *linker,
> >          scope = aml_scope("\\_SB.PCI0.ISA");
> >  
> >          dev = aml_device("PEVR");
> > -        aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0002")));
> > +        aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0001")));
> >  
> >          crs = aml_resource_template();
> >          aml_append(crs,
> > 
> 
> Pretty obvious, so I can take this through my tree.
Thanks!

I'll post additional test patch for 2.4
> 
> Paolo
>