[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 12/15] Add optional parameters to QMP command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions |
Date: |
Mon, 30 Mar 2015 14:28:01 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 03/30/2015 08:28 AM, Michael Mueller wrote:
> The patch adds optional parameters to the QMP command query-cpu-definitions.
> Thus the signature of routine arch_query_cpu_definitions needs to be changed
> for the stub function and all target implementations:
>
> target-arm
> target-i386
> target-ppc
> target-s390
>
> Signed-off-by: Michael Mueller <address@hidden>
> ---
> +++ b/qapi-schema.json
> @@ -2532,21 +2532,31 @@
> #
> # @name: the name of the CPU definition
> #
> +# @default: #optional defines if cpu model is the default (since 2.4)
Reads poorly. How about:
# @default: #optional true if cpu model is the default, omitted if false
(since 2.4)
> +#
> +# @runnable: #optional defines if cpu model is runnable (since 2.4)
Similarly:
# @runnable: #optional true if cpu model is runnable, omitted if false
(since 2.4)
> +#
> # Since: 1.2.0
> ##
> { 'type': 'CpuDefinitionInfo',
> - 'data': { 'name': 'str' } }
> + 'data': { 'name': 'str', '*is-default': 'bool', '*runnable': 'bool' } }
>
> ##
> # @query-cpu-definitions:
> #
> # Return a list of supported virtual CPU definitions
> #
> +# @machine: #optional machine type (since 2.4)
> +#
> +# @accel: #optional accelerator id (since 2.4)
Maybe mention that these two fields are for filtering results.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 06/15] target-s390x: Add cpu model alias definition routines, (continued)
- [Qemu-devel] [PATCH v4 06/15] target-s390x: Add cpu model alias definition routines, Michael Mueller, 2015/03/30
- [Qemu-devel] [PATCH v4 09/15] target-s390x: Add cpu class initialization routines, Michael Mueller, 2015/03/30
- [Qemu-devel] [PATCH v4 03/15] target-s390x: Generate facility defines per cpu model, Michael Mueller, 2015/03/30
- [Qemu-devel] [PATCH v4 08/15] target-s390x: Add KVM VM attribute interface for cpu models, Michael Mueller, 2015/03/30
- [Qemu-devel] [PATCH v4 10/15] target-s390x: Prepare accelerator during cpu object realization, Michael Mueller, 2015/03/30
- [Qemu-devel] [PATCH v4 14/15] target-s390x: Introduce facility test routine, Michael Mueller, 2015/03/30
- [Qemu-devel] [PATCH v4 15/15] target-s390x: Enable cpu model usage, Michael Mueller, 2015/03/30
- [Qemu-devel] [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions, Michael Mueller, 2015/03/30
- [Qemu-devel] [PATCH v4 02/15] target-s390x: Introduce cpu facilities, Michael Mueller, 2015/03/30
- [Qemu-devel] [PATCH v4 13/15] target-s390x: Extend QMP command query-cpu-definitions, Michael Mueller, 2015/03/30
- [Qemu-devel] [PATCH v4 07/15] target-s390x: Update linux-headers/asm-s390/kvm.h, Michael Mueller, 2015/03/30