[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] rcu: do not create thread in pthread_atfork cal
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] rcu: do not create thread in pthread_atfork callback |
Date: |
Tue, 31 Mar 2015 13:59:56 +0100 |
On 31 March 2015 at 13:55, Paolo Bonzini <address@hidden> wrote:
>
>
> On 31/03/2015 13:41, Peter Maydell wrote:
>>> > static void __attribute__((__constructor__)) rcu_init(void)
>>> > {
>>> > #ifdef CONFIG_POSIX
>>> > - pthread_atfork(rcu_init_lock, rcu_init_unlock, rcu_init_child);
>>> > + pthread_atfork(rcu_init_lock, rcu_init_unlock, rcu_init_unlock);
>>> > #endif
>>> > rcu_init_complete();
>>> > }
>> So this is changing the linux-user behaviour so we no
>> longer do any init after fork; is that a problem?
>
> Currently linux-user is not using RCU at all, so no. Should I add an
> rcu_after_fork there too?
Well, I don't really understand the rcu stuff, so I can't
say...
-- PMM