Re: [Qemu-devel] [PATCH COLO v3 08/14] Allow creating backup jobs when opening BDS

[Paolo Bonzini]

On 03/04/2015 12:01, Wen Congyang wrote:
> When opening BDS, we need to create backup jobs for
> image-fleecing. This feature is not used by qemu-img,
> qemu-io or qemu-nbd. So just adding the referenced
> functions to stubs.
> 
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
>  stubs/Makefile.objs |  1 +
>  stubs/backup.c      | 11 +++++++++++
>  2 files changed, 12 insertions(+)
>  create mode 100644 stubs/backup.c
> 
> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
> index 8beff4c..5ae2214 100644
> --- a/stubs/Makefile.objs
> +++ b/stubs/Makefile.objs
> @@ -39,3 +39,4 @@ stub-obj-$(CONFIG_WIN32) += fd-register.o
>  stub-obj-y += cpus.o
>  stub-obj-y += kvm.o
>  stub-obj-y += qmp_pc_dimm_device_list.o
> +stub-obj-y += backup.o
> diff --git a/stubs/backup.c b/stubs/backup.c
> new file mode 100644
> index 0000000..3ebcc71
> --- /dev/null
> +++ b/stubs/backup.c
> @@ -0,0 +1,11 @@
> +#include "block/block_int.h"
> +
> +void backup_start(BlockDriverState *bs, BlockDriverState *target,
> +                  int64_t speed, MirrorSyncMode sync_mode,
> +                  BlockdevOnError on_source_error,
> +                  BlockdevOnError on_target_error,
> +                  BlockCompletionFunc *cb, void *opaque,
> +                  Error **errp)
> +{
> +    error_setg(errp, "this feature or command is not currently supported");
> +}
> 

I wouldn't mind just moving block/backup.o from common-objs-y to
block-objs-y.

Paolo