[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH] block/iscsi: handle zero events fr
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH] block/iscsi: handle zero events from iscsi_which_events |
Date: |
Wed, 8 Apr 2015 09:38:38 +0100 |
On Tue, Apr 7, 2015 at 9:08 PM, Peter Lieven <address@hidden> wrote:
Please CC address@hidden in the future. All patches must be on
the qemu-devel mailing list so they can be merged (for transparency).
I have added qemu-devel to CC.
> + /* newer versions of libiscsi may return zero events. In this
> + * case start a timer to ensure we are able to return to service
> + * once this situation changes. */
> + if (!ev) {
> + timer_mod(iscsilun->event_timer,
> + qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + EVENT_INTERVAL);
> }
This suggests that libiscsi is waiting on its own internal timer. It
would be cleaner for libiscsi to provide a timeout value so the
application doesn't need to poll the library. Is there still scope to
modify libiscsi to do this?
- Re: [Qemu-devel] [Qemu-block] [PATCH] block/iscsi: handle zero events from iscsi_which_events,
Stefan Hajnoczi <=