Re: [Qemu-devel] [PATCH RFC 02/19] qapi: Fix C identifiers generated for names containing '.'

[Eric Blake]

On 04/06/2015 05:25 PM, Eric Blake wrote:
> On 04/02/2015 11:28 AM, Markus Armbruster wrote:
>> c_fun() maps '.' to '_', c_var() doesn't.  Nothing prevents '.' in
>> QAPI names that get passed to c_var().
>>
>> Which QAPI names get passed to c_fun(), to c_var(), or to both is not
>> obvious.  Names of command parameters and struct type members get
>> passed to c_var().
>>
>> c_var() strips a leading '*', but this cannot happen.  c_fun()
>> doesn't.
>>
>> Fix c_var() to work exactly like c_fun().
>>
>> Perhaps they should be replaced by a single mapping function.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  scripts/qapi.py | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> In order to test if we caught everything, I tried adding:
> 

I took over this one patch, and turned it into a series:

https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg01300.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature