[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v7 12/14] migration: Use an array instead of 3 paramet
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [v7 12/14] migration: Use an array instead of 3 parameters |
Date: |
Tue, 14 Apr 2015 06:01:32 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/08/2015 05:37 AM, Juan Quintela wrote:
> Liang Li <address@hidden> wrote:
>> Put the three parameters related to multiple thread (de)compression
>> into an int array, and use an enum type to index the parameter.
>>
>> Signed-off-by: Liang Li <address@hidden>
>> Signed-off-by: Yang Zhang <address@hidden>
>
> Reviewed-by: Juan Quintela <address@hidden>
>
>
> BTW, for the libvirt people, what do you think about moving the other
> parameters here, and make the other accessors deprecated?
>
> I mean here:
> - xbzrle_cache_size
> -> get mbps
> -> set/get migration_speed
> -> get/set migration_downtime
> -> autoconverge?
>
> You get the idea.
Setting multiple bits through one command is nicer. Libvirt will still
have to keep the code for driving older qemu, but I'm not opposed to
consolidation.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [v7 13/14] migration: Add qmp commands to set and query parameters, Liang Li, 2015/04/08
Re: [Qemu-devel] [v7 13/14] migration: Add qmp commands to set and query parameters, Eric Blake, 2015/04/14
[Qemu-devel] [v7 14/14] migration: Add hmp interface to set and query parameters, Liang Li, 2015/04/08