Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

[Leon Alrae]

On 15/04/2015 13:06, Liviu Ionescu wrote:
> 
>> On 15 Apr 2015, at 14:53, Leon Alrae <address@hidden> wrote:
>>
>> On 15/04/2015 10:09, Liviu Ionescu wrote:
>>> Peter/Leon,
>>>
>>> I'm planning for my future releases, and, to avoid incompatible versions, I 
>>> would like to help with the semihosting configuration issue, to speed up 
>>> things. is there any chance to close this issue in the near future?
>>
>> I'm hoping so :) I'm holding up UHI patches respin until we resolve this.
> 
> how do you suggest we should proceed?

If there aren't any objections for the proposed solution, then let's
just cook up the patch. It would be nice to get ACK/NACK from Peter as
initially it was suggested to avoid adding top level arguments.
But I think there were reasonable enough arguments for having top level
--semihosting-cmdline placed at the end of command line.

> 
>>> we currently have two solutions:
>>>
>>> - multiple: --semihosting-config arg="..." 
>>> - a single option, placed at the end, and followed by any number of 
>>> arguments: --semihosting-cmdline $@ \n
>>>
>>> both can generate the array of args required by UHI and both can pass args 
>>> with spaces.
>>>
>>> the second one is more scripting friendly, and is somehow in the spirit of 
>>> other unix programs that need to pass such arguments.
>>
>> I don't have a strong preference here, but I think I would be leaning
>> towards the second one as it just looks better. On the other hand it
>> reserves the last position in the QEMU command line, which I'm not sure
>> if can become a problem at some point?
> 
> do you have anything specific in mind? I don't know qemu very well, but apart 
> from setting semihosting and kernel args, I doubt there are other use cases 
> to require variable number of arguments. 

No, I don't.

Leon