Re: [Qemu-devel] [PATCH for-2.4 07/10] block/iscsi: bump libiscsi requirement to 1.10.0

[Peter Lieven]

Am 16.04.2015 um 14:33 schrieb Paolo Bonzini:
> On 16/04/2015 14:18, Peter Lieven wrote:
> > We need this to support SCSI_STATUS_TASK_SET_FULL.
> Any reason apart from the missing constant?

No, but I wanted to avoid starting checking for constants that were added 
shortly after this.
You can't check with #ifdef for a constant in an enum.
Libiscsi 1.10 was released in September 2013.

Peter


> Paolo
>
> > Signed-off-by: Peter Lieven <address@hidden>
> > ---
> >   configure | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/configure b/configure
> > index 6969f6f..f73b8d0 100755
> > --- a/configure
> > +++ b/configure
> > @@ -3630,15 +3630,15 @@ if compile_prog "" "" ; then
> >   fi
> >   
> >   ##########################################
> > -# Do we have libiscsi >= 1.9.0
> > +# Do we have libiscsi >= 1.10.0
> >   if test "$libiscsi" != "no" ; then
> > -  if $pkg_config --atleast-version=1.9.0 libiscsi; then
> > +  if $pkg_config --atleast-version=1.10.0 libiscsi; then
> >       libiscsi="yes"
> >       libiscsi_cflags=$($pkg_config --cflags libiscsi)
> >       libiscsi_libs=$($pkg_config --libs libiscsi)
> >     else
> >       if test "$libiscsi" = "yes" ; then
> > -      feature_not_found "libiscsi" "Install libiscsi >= 1.9.0"
> > +      feature_not_found "libiscsi" "Install libiscsi >= 1.10.0"
> >       fi
> >       libiscsi="no"
> >     fi


--

Mit freundlichen Grüßen

Peter Lieven

...........................................................

  KAMP Netzwerkdienste GmbH
  Vestische Str. 89-91 | 46117 Oberhausen
  Tel: +49 (0) 208.89 402-50 | Fax: +49 (0) 208.89 402-40
  address@hidden | http://www.kamp.de

  Geschäftsführer: Heiner Lante | Michael Lante
  Amtsgericht Duisburg | HRB Nr. 12154
  USt-Id-Nr.: DE 120607556

...........................................................