qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 RFC 06/34] qom: add a object_property_add_enu


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v1 RFC 06/34] qom: add a object_property_add_enum helper method
Date: Fri, 17 Apr 2015 17:19:31 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0


On 17/04/2015 17:11, Daniel P. Berrange wrote:
> > On second thought (after seeing patch 7), please add a property type
> > argument here.  We lose introspection of enum property types otherwise.
> 
> Can you give me a pointer to where we lose introspection ? The hostmem
> code just registers its 'policy' property with a type name of 'str',

That was already a bug. :(  It should have been registered as 
"HostMemPolicy".  See for example:

$ qemu-system-x86_64 -device ide-hd,help
ide-hd.bootindex=int32
ide-hd.unit=uint32
ide-hd.bios-chs-trans=BiosAtaTranslation (Logical CHS translation algorithm, 
auto/none/lba/large/rechs)
...

> which I've just changed to 'enum' in patch 7, so I didn't think I was
> regressing anything. Is there some QMP command which you think looses
> the info that I can verify.

The qom-list command returns a list of property names and types.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]