Re: [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly

[Stefan Hajnoczi]

On Thu, Mar 26, 2015 at 06:38:22PM +0100, Paolo Bonzini wrote:
> diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c
> index 46f7b41..be62dd6 100644
> --- a/hw/display/g364fb.c
> +++ b/hw/display/g364fb.c
> @@ -489,7 +489,7 @@ static void g364fb_init(DeviceState *dev, G364State *s)
>      memory_region_init_ram_ptr(&s->mem_vram, NULL, "vram",
>                                 s->vram_size, s->vram);
>      vmstate_register_ram(&s->mem_vram, dev);
> -    memory_region_set_coalescing(&s->mem_vram);
> +    memory_region_set_log(&s->mem_vram, true, DIRTY_MEMORY_VGA);

This change isn't 100% clear to me.  I guess that coalescing
(performance optimization) doesn't make sense when logging is enabled?

pgpzHigeK105_.pgp
Description: PGP signature