Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

[Gerd Hoffmann]

On Di, 2015-04-21 at 17:08 +0200, Paolo Bonzini wrote:
> 
> On 21/04/2015 17:04, Gerd Hoffmann wrote:
> > Hmm.  I think if we merge all the smm / smram / tseg patches in one go
> > this should work.  Without patches reading the ESMRAMC register returns
> > zero.  With the patches the three cache-disable bits are hardcoded to
> > '1'.  This should work for detecting tseg support.
> > 
> > You also have to test for smm support.  The current protocol for this is
> > that seabios checks whenever smm is already initialized (see
> > *_apmc_smm_setup() in seabios/src/fw/smm.c) and if so it skips smm
> > initialization.  Right now qemu sets the bit on reset when running on
> > kvm, so seabios doesn't try to use smm.  On tcg the bit is clear after
> > reset and seabios actually uses smm mode.
> 
> BTW, I plan to add "-machine smm=yes/no/auto".
> 
> Gerd, are you going to implement SMI_EN locking as well?

Sure, can do that while being at it.

cheers,
  Gerd