Re: [Qemu-devel] [PATCH 01/10] s390x/kvm: Remove message about "switch_amode" kernel parameter

[Christian Borntraeger]

Am 09.04.2015 um 10:51 schrieb Cornelia Huck:
> From: Thomas Huth <address@hidden>
> 
> The "switch_amode" parameter has been removed from the Linux kernel
> sources since version 3.7 - so QEMU should not advise this parameter
> nowadays anymore.
> 
> Signed-off-by: Thomas Huth <address@hidden>
> Acked-by: Cornelia Huck <address@hidden>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
>  kvm-all.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/kvm-all.c b/kvm-all.c
> index dd44f8c..7c8537b 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1542,11 +1542,6 @@ static int kvm_init(MachineState *ms)
>      if (ret < 0) {
>          fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -ret,
>                  strerror(-ret));
> -
> -#ifdef TARGET_S390X
> -        fprintf(stderr, "Please add the 'switch_amode' kernel parameter to "
> -                        "your host kernel command line\n");
> -#endif
>          goto err;
>      }
> 

Can you drop this patch from your upcoming pull request?

See the discussion on http://marc.info/?l=kvm&m=142978728714865&w=2
We might want to change the error message instead of getting rid of it.

Christian