Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu

[Corey Minyard]

On 04/24/2015 04:38 AM, Paolo Bonzini wrote:
>
> On 24/04/2015 00:57, address@hidden wrote:
>> The major changes from last time are:
>>
>> * Don't use callbacks for adding firmware tables, provide binary
>>   blobs instead.
>>
>> * Add the SSDT as a separate table.
>>
>> * Modify the BIOS tests to test for the IPMI tables.
> I disagree with both of the first two changes, but thanks for doing them
> nevertheless.  Michael, is this okay with you now?

To me it was not a big deal either way.  The change made the code a
bit more consistent with what was already there, and having the SSDT
as a separate table made the testing a lot easier, as Michael said it
would.

-corey