[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH target-arm v4 04/16] arm: Introduce Xilinx ZynqM
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH target-arm v4 04/16] arm: Introduce Xilinx ZynqMP SoC |
Date: |
Fri, 24 Apr 2015 16:26:29 +0100 |
On 23 April 2015 at 22:38, Peter Maydell <address@hidden> wrote:
> On 23 April 2015 at 20:21, Peter Crosthwaite
> <address@hidden> wrote:
>> On Thu, Apr 23, 2015 at 10:42 AM, Peter Maydell
>> <address@hidden> wrote:
>>> On 23 March 2015 at 11:05, Peter Crosthwaite
>>> <address@hidden> wrote:
>>>> --- a/hw/arm/Makefile.objs
>>>> +++ b/hw/arm/Makefile.objs
>>>> @@ -10,3 +10,4 @@ obj-$(CONFIG_DIGIC) += digic.o
>>>> obj-y += omap1.o omap2.o strongarm.o
>>>> obj-$(CONFIG_ALLWINNER_A10) += allwinner-a10.o cubieboard.o
>>>> obj-$(CONFIG_STM32F205_SOC) += stm32f205_soc.o
>>>> +obj-$(CONFIG_XLNX_ZYNQMP) += xlnx-zynqmp.o
>>>
>>> Can this be a common-obj- ?
>>>
>>
>> Seems to build fine. I'll make this change. It's inconsistent with
>> surrounding code so I guess this is a new policy?
>
> Historically this makefile's objects were only built for
> ARM targets anyway, so it didn't make much difference.
> Now we have aarch64 it avoids building a .o twice
I looked a bit more closely at this, and hw/arm is treated
specially (the hw/$(TARGET_BASE_ARCH) directories are
pulled in directly by Makefile.target and only for obj-y),
so for now new object files in this directory should just be
in obj-. I might see if we can add support for common-obj-y,
but that's a separate patch.
thanks
-- PMM