[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends
From: |
Shannon Zhao |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends |
Date: |
Wed, 29 Apr 2015 17:55:37 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 2015/4/28 21:16, Peter Maydell wrote:
> On 28 April 2015 at 14:13, Michael S. Tsirkin <address@hidden> wrote:
>> > The patches look correct to me too, but I want s390
>> > cleaned up so it does not include COMMON_FEATURES
>> > in 100 places, and I prefer merging it all together.
> It seems a bit harsh to ask Shannon to do s390 cleanup when
> he doesn't have any access to s390 guests or test cases...
> Making S390 put COMMON_FEATURES in the right places seems
> to me like a separate bit of s390-specific cleanup.
>
> (The other cleanup we could do after this patchset would
> be to just expand out the DEFINE_VIRTIO_NET/RNG/SCSI/etc_FEATURES
> macros which are all now used in exactly one place. But
right, will send another patchset to do this.
--
Shannon
- Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends, (continued)
- Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends, Michael S. Tsirkin, 2015/04/28
- Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends, Michael S. Tsirkin, 2015/04/28
- Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends, Michael S. Tsirkin, 2015/04/28
- Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends, Christian Borntraeger, 2015/04/29
- Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends, Cornelia Huck, 2015/04/29
- Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends, Michael S. Tsirkin, 2015/04/29
- Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends, Cornelia Huck, 2015/04/29
- Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends, Christian Borntraeger, 2015/04/29
- Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends, Peter Maydell, 2015/04/28
- Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends, Michael S. Tsirkin, 2015/04/28
- Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends,
Shannon Zhao <=