Re: [Qemu-devel] [PATCH v4 0/7] aio: Support epoll by introducing qemu_poll abstraction

[Kevin Wolf]

Am 29.04.2015 um 05:24 hat Fam Zheng geschrieben:
> v4: Rebase to 2.3 and rerun tests.  timerfd+epoll shows clear improvement over
>     current master when the virtio-console device attaches more fds to the 
> main
>     loop:
> 
>     syscall         high # of fd      low # of fd
>     -------------------------------------------------
>     qemu.git(ppoll) 24                83
>     ppoll+epoll     49                82
>     timerfd+epoll   49                91
>     glib            20                82
> 
>     (In high # of fd case, 3 activated but idle virtio-console devices are
>     attached, which will add us hundereds of fds to poll)
> 
>     Although a new epoll_pwait1 syscall is still being worked on [1], the QEMU
>     part to make use of that (if any) will base on this, so let's merge it
>     first.
>     
>     [1]: http://www.spinics.net/lists/linux-api/msg08216.html

Doesn't even build with mingw:

    /mnt/qemu/main-loop.c: In function 'os_host_main_loop_wait':
    /mnt/qemu/main-loop.c:463:5: error: expected ';' before 'nevents'
         nevents = qemu_poll(qpoll, poll_timeout_ns);
         ^
    /mnt/qemu/main-loop.c:467:9: error: 'r' undeclared (first use in this 
function)
             r = qemu_poll_get_events(qpoll, poll_events, nevents);
             ^
    /mnt/qemu/main-loop.c:467:9: note: each undeclared identifier is reported 
only once for each function it appears in
    /mnt/qemu/main-loop.c:411:20: warning: unused variable 'events' 
[-Wunused-variable]
         QEMUPollEvent *events;
                        ^
    make: *** [main-loop.o] Fehler 1

Before you fix that and resend another version as "it compiles, let's
ship it": My expectation for patches that touch platform specific code
isn't only a build test, but that your actually ran it.

Kevin