[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] .gitignore contains .c and .h ?

From: Guillaume Le Louët
Subject: Re: [Qemu-devel] .gitignore contains .c and .h ?
Date: Mon, 04 May 2015 13:37:46 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

You're right, I noticed that compiling with make was removing my modifications.
I ended up modifying the qapi-schema.json .

May I advise to move the generated .c and .h files into a generated/ folder ?

Thank you Thomas.

Le 04/05/2015 13:01, Thomas Huth a écrit :
On Mon, 04 May 2015 09:47:11 +0200
Guillaume Le Louët <address@hidden> wrote:


The .gitignore in the master branch contains the following lines :

Why is it so ? Are they generated automatically each time I compile the
project ?
I am modifying qapi-types.h and qapi-types.c , am I doing wrong ?
Yes, they are created automatically and you should not edit them
manually. Just have a look at the main Makefile:

qapi-modules = $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi/common.json \
                $(SRC_PATH)/qapi/block.json $(SRC_PATH)/qapi/block-core.json \

qapi-types.c qapi-types.h :\
$(qapi-modules) $(SRC_PATH)/scripts/qapi-types.py $(qapi-py)
         $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-types.py \
                 $(gen-out-type) -o "." -b -i $<, \
                 "  GEN   $@")

So if you want to change something in this area, you likely have to
touch the *.json files instead.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]