[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] cpu: Register QOM links at /machine/cpus/<index
Re: [Qemu-devel] [PATCH] cpu: Register QOM links at /machine/cpus/<index>
Mon, 4 May 2015 15:16:16 +0200
On Mon, 04 May 2015 11:59:52 +0200
Paolo Bonzini <address@hidden> wrote:
> On 04/05/2015 11:47, Igor Mammedov wrote:
> > On Thu, 30 Apr 2015 16:19:07 -0300
> > Eduardo Habkost <address@hidden> wrote:
> > > This will provide a predictable path for the CPU objects, and a
> > > more powerful alternative for the query-cpus QMP command, as now
> > > every QOM property on CPU objects can be easily queried.
> > provided the way cpu_index is generated, path won't be
> > predictable/stable with CPU unplug. I'd rather use DEVICE->id
> > instead of cpu_index.
> Can we use the APIC id then? Perhaps wrapped with a CPUState-level
> method get_stable_processor_id()?
We have CPUClass->get_arch_id() which results in APIC id for
But I'd rather see an arbitrary DEVICE->id as index/name, that way
when -device cpu-foo,id=cpuXXX becomes functional we would have
1:1 mapping between CLI and /machine/cpus/ view.