[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with buf

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write
Date: Tue, 05 May 2015 12:35:44 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 02/05/2015 02:13, John Snow wrote:
> I wrote a loop to batch the ascii-hex conversion instead of letting
> printf do it; then ran some more very, very scientific tests:
> memset alone:
> real    0m10.888s
> user    0m9.303s
> sys    0m9.146s
> send-batching:
> real    0m6.541s
> user    0m5.027s
> sys    0m4.941s
> memset+batching+b64:
> real    0m3.675s
> user    0m2.582s
> sys    0m1.718s
> So it still seems as if the b64 batching is a strict improvement
> speed-wise. I'll send the non-b64 batching patch separately later,
> unless you have thoughts otherwise.

Ok, this is more similar to what I'd expect (3.6 * 6 / 4 = 5.4, I'm not
sure if you have the memset optimization in the send-batching test).

Hex is obviously more debuggable compared to Base64 (unless you starred
in the Matrix movies), so I'm a bit undecided about this one.  Anyone
can break the tie?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]