[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 07/15] migration: Split save_zero_page from ram_save_
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PULL 07/15] migration: Split save_zero_page from ram_save_page |
Date: |
Wed, 6 May 2015 19:49:56 +0200 |
From: Liang Li <address@hidden>
Split the function save_zero_page from ram_save_page so that we can
reuse it later.
Signed-off-by: Liang Li <address@hidden>
Signed-off-by: Yang Zhang <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
arch_init.c | 61 +++++++++++++++++++++++++++++++++++++++++++------------------
1 file changed, 43 insertions(+), 18 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index ebd246f..48cae22 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -716,6 +716,34 @@ static void migration_bitmap_sync(void)
}
/**
+ * save_zero_page: Send the zero page to the stream
+ *
+ * Returns: Number of pages written.
+ *
+ * @f: QEMUFile where to send the data
+ * @block: block that contains the page we want to send
+ * @offset: offset inside the block for the page
+ * @p: pointer to the page
+ * @bytes_transferred: increase it with the number of transferred bytes
+ */
+static int save_zero_page(QEMUFile *f, RAMBlock *block, ram_addr_t offset,
+ uint8_t *p, uint64_t *bytes_transferred)
+{
+ int pages = -1;
+
+ if (is_zero_range(p, TARGET_PAGE_SIZE)) {
+ acct_info.dup_pages++;
+ *bytes_transferred += save_page_header(f, block,
+ offset |
RAM_SAVE_FLAG_COMPRESS);
+ qemu_put_byte(f, 0);
+ *bytes_transferred += 1;
+ pages = 1;
+ }
+
+ return pages;
+}
+
+/**
* ram_save_page: Send the given page to the stream
*
* Returns: Number of pages written.
@@ -763,25 +791,22 @@ static int ram_save_page(QEMUFile *f, RAMBlock* block,
ram_addr_t offset,
acct_info.dup_pages++;
}
}
- } else if (is_zero_range(p, TARGET_PAGE_SIZE)) {
- acct_info.dup_pages++;
- *bytes_transferred += save_page_header(f, block,
- offset |
RAM_SAVE_FLAG_COMPRESS);
- qemu_put_byte(f, 0);
- *bytes_transferred += 1;
- pages = 1;
- /* Must let xbzrle know, otherwise a previous (now 0'd) cached
- * page would be stale
- */
- xbzrle_cache_zero_page(current_addr);
- } else if (!ram_bulk_stage && migrate_use_xbzrle()) {
- pages = save_xbzrle_page(f, &p, current_addr, block,
- offset, last_stage, bytes_transferred);
- if (!last_stage) {
- /* Can't send this cached data async, since the cache page
- * might get updated before it gets to the wire
+ } else {
+ pages = save_zero_page(f, block, offset, p, bytes_transferred);
+ if (pages > 0) {
+ /* Must let xbzrle know, otherwise a previous (now 0'd) cached
+ * page would be stale
*/
- send_async = false;
+ xbzrle_cache_zero_page(current_addr);
+ } else if (!ram_bulk_stage && migrate_use_xbzrle()) {
+ pages = save_xbzrle_page(f, &p, current_addr, block,
+ offset, last_stage, bytes_transferred);
+ if (!last_stage) {
+ /* Can't send this cached data async, since the cache page
+ * might get updated before it gets to the wire
+ */
+ send_async = false;
+ }
}
}
--
2.4.0
- [Qemu-devel] [PULL 00/15] migration pull request, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 01/15] docs: Add a doc about multiple thread compression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 04/15] qemu-file: Add compression functions to QEMUFile, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 05/15] arch_init: Alloc and free data struct for compression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 02/15] migration: Add the framework of multi-thread compression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 06/15] arch_init: Add and free data struct for decompression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 03/15] migration: Add the framework of multi-thread decompression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 07/15] migration: Split save_zero_page from ram_save_page,
Juan Quintela <=
- [Qemu-devel] [PULL 08/15] migration: Add the core code of multi-thread compression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 09/15] migration: Make compression co-work with xbzrle, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 10/15] migration: Add the core code for decompression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 11/15] migration: Add interface to control compression, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 15/15] migration: avoid divide by zero in xbzrle cache miss rate, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 13/15] migration: Add qmp commands to set and query parameters, Juan Quintela, 2015/05/06
- [Qemu-devel] [PULL 12/15] migration: Use an array instead of 3 parameters, Juan Quintela, 2015/05/06