[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 29/34] qemu-iotests: Remove cache mode test without
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 29/34] qemu-iotests: Remove cache mode test without medium |
Date: |
Fri, 8 May 2015 19:22:01 +0200 |
Specifying the cache mode for a driver without a medium is not a useful
thing to do: As long as there is no medium, the cache mode doesn't make
a difference, and once the 'change' command is used to insert a medium,
it ignores the old cache mode and makes the new medium use
cache=writethrough.
Later patches will make it an error to specify the cache mode for an
empty drive. Remove the corresponding test case.
Signed-off-by: Kevin Wolf <address@hidden>
---
tests/qemu-iotests/051 | 14 --------------
tests/qemu-iotests/051.out | 26 --------------------------
2 files changed, 40 deletions(-)
diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
index 0360f37..e236685 100755
--- a/tests/qemu-iotests/051
+++ b/tests/qemu-iotests/051
@@ -176,20 +176,6 @@ run_qemu -drive
file="$TEST_IMG",if=none,id=disk,readonly=on -device lsi53c895a
run_qemu -drive file="$TEST_IMG",if=none,id=disk,readonly=on -device
lsi53c895a -device scsi-hd,drive=disk
echo
-echo === Cache modes ===
-echo
-
-# Cannot use the test image because cache=none might not work on the host FS
-# Use cdrom so that we won't get errors about missing media
-
-run_qemu -drive media=cdrom,cache=none
-run_qemu -drive media=cdrom,cache=directsync
-run_qemu -drive media=cdrom,cache=writeback
-run_qemu -drive media=cdrom,cache=writethrough
-run_qemu -drive media=cdrom,cache=unsafe
-run_qemu -drive media=cdrom,cache=invalid_value
-
-echo
echo === Specifying the protocol layer ===
echo
diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out
index 2890eac..2e3b48a 100644
--- a/tests/qemu-iotests/051.out
+++ b/tests/qemu-iotests/051.out
@@ -221,32 +221,6 @@ QEMU X.Y.Z monitor - type 'help' for more information
(qemu) q[K[Dqu[K[D[Dqui[K[D[D[Dquit[K
-=== Cache modes ===
-
-Testing: -drive media=cdrom,cache=none
-QEMU X.Y.Z monitor - type 'help' for more information
-(qemu) q[K[Dqu[K[D[Dqui[K[D[D[Dquit[K
-
-Testing: -drive media=cdrom,cache=directsync
-QEMU X.Y.Z monitor - type 'help' for more information
-(qemu) q[K[Dqu[K[D[Dqui[K[D[D[Dquit[K
-
-Testing: -drive media=cdrom,cache=writeback
-QEMU X.Y.Z monitor - type 'help' for more information
-(qemu) q[K[Dqu[K[D[Dqui[K[D[D[Dquit[K
-
-Testing: -drive media=cdrom,cache=writethrough
-QEMU X.Y.Z monitor - type 'help' for more information
-(qemu) q[K[Dqu[K[D[Dqui[K[D[D[Dquit[K
-
-Testing: -drive media=cdrom,cache=unsafe
-QEMU X.Y.Z monitor - type 'help' for more information
-(qemu) q[K[Dqu[K[D[Dqui[K[D[D[Dquit[K
-
-Testing: -drive media=cdrom,cache=invalid_value
-QEMU_PROG: -drive media=cdrom,cache=invalid_value: invalid cache option
-
-
=== Specifying the protocol layer ===
Testing: -drive file=TEST_DIR/t.qcow2,file.driver=file
--
1.8.3.1
- Re: [Qemu-devel] [PATCH 25/34] block: Allow specifying child options in reopen, (continued)
- [Qemu-devel] [PATCH 26/34] block: reopen: Document option precedence and refactor accordingly, Kevin Wolf, 2015/05/08
- [Qemu-devel] [PATCH 24/34] block: Keep "driver" in bs->options, Kevin Wolf, 2015/05/08
- [Qemu-devel] [PATCH 27/34] block: Add infrastructure for option inheritance, Kevin Wolf, 2015/05/08
- [Qemu-devel] [PATCH 28/34] block: Introduce bs->explicit_options, Kevin Wolf, 2015/05/08
- [Qemu-devel] [PATCH 29/34] qemu-iotests: Remove cache mode test without medium,
Kevin Wolf <=
- [Qemu-devel] [PATCH 30/34] block: reopen: Extract QemuOpts for generic block layer options, Kevin Wolf, 2015/05/08
- [Qemu-devel] [PATCH 31/34] block: Move cache options into options QDict, Kevin Wolf, 2015/05/08
- [Qemu-devel] [PATCH 32/34] qemu-iotests: Try setting cache mode for children, Kevin Wolf, 2015/05/08
- [Qemu-devel] [PATCH 34/34] qemu-iotests: Test reopen with node-name/driver options, Kevin Wolf, 2015/05/08