[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/34] block: Add list of children to BlockDrive
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 08/34] block: Add list of children to BlockDriverState |
Date: |
Fri, 08 May 2015 17:34:19 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
> This allows iterating over all children of a given BDS, not only
> including bs->file and bs->backing_hd, but also driver-specific
> ones like VMDK extents or Quorum children.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 27 +++++++++++++++++++++++++++
> include/block/block_int.h | 8 ++++++++
> 2 files changed, 35 insertions(+)
>
Reviewed-by: Eric Blake <address@hidden>
and now I'm starting to see why you passed a well-named instance of a
struct that contains only a single function pointer, rather than the
function pointer directly, when creating BdrvChildRole in patch 7.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 09/34] block: Add BlockDriverState.inherits_from, (continued)