Re: [Qemu-devel] [PATCH v2] Fixes key mapping so all keys work

[Peter Maydell]

On 15 January 2015 at 21:13, Programmingkid <address@hidden> wrote:
> Fixes keyboard mapping so right shift, right command, right option, right 
> control, keypad period, keypad '=', keypad enter, and F13 all work.
>
> Signed-off-by: John Arbuckle <address@hidden>
>
> ---
> Undid most changes to keyboard map in cocoa.m.
> Most changes made to keyboard map in adb.c.
> Since there is no keypad '=' key for the PC/AT or PC/XT layouts, I had to 
> invent my own number for it. It works for the Mac OS X guest. Guest like 
> Windows XP are not effected because they don't use the Macintosh keyboard 
> layout.
>
> Signed-off-by: John Arbuckle <address@hidden>
>
> ---
>  hw/input/adb.c |    8 ++++----
>  ui/cocoa.m     |    4 ++--

This is two conceptually separate fixes:
 (1) better handle key input to the ADB keyboard
 (2) output the right keycodes on the OSX cocoa UI
which should be in separate patches.

We should also be doing the support for keypad-= by converting both
the cocoa UI and the ADB keyboard device to the QKeyCode APIs,
which can cleanly handle these key without inventing fake PC
keycode numbers, as suggested by Gerd:
https://lists.gnu.org/archive/html/qemu-devel/2015-02/msg01322.html

My apologies for this review being so delayed; I'm now
trying to process my queue of OSX to-review patches.

-- PMM