qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View m


From: Programmingkid
Subject: Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu
Date: Mon, 11 May 2015 10:38:38 -0400

On May 11, 2015, at 10:33 AM, Peter Maydell wrote:

> On 11 May 2015 at 15:29, Programmingkid <address@hidden> wrote:
>> 
>> On May 11, 2015, at 9:20 AM, Peter Maydell wrote:
>>> Can't we just create a menu with an item for every console,
>>> and set its menu text to the result of qemu_console_get_label() ?
>>> I don't see why we need to special case these four and only
>>> display those.
> 
>> We *could* do it that way, but it wouldn't look pretty. Instead of having 
>> these menu items:
>> 
>> VGA, Monitor, Serial, Parallel
>> 
>> We would have these menu items:
>> 
>> VGA
>> compat_monitor0
>> serial0
>> parallel0
>> 
>> They look very anti-pretty.
> 
> They're the menu entries we have in the GTK UI. If you want
> pretty names then you should fix this in the common code
> so that any UI that wants to display pretty names can do
> that. Having the OSX UI do things differently is not a
> good idea.

I know your big on having the interface be consistent between operating 
systems, but my experience is Linux users use only Linux software and Mac users 
use only Mac software. It is possible there is someone out there who uses both 
the Mac OS and Linux versions of QEMU. I'm just not going to bet on it. 

I will have a patch for your idea available soon.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]