[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] block: align bounce buffers to
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] block: align bounce buffers to page |
Date: |
Mon, 11 May 2015 15:54:37 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, May 04, 2015 at 04:42:24PM +0300, Denis V. Lunev wrote:
> @@ -726,7 +727,8 @@ static void raw_refresh_limits(BlockDriverState *bs,
> Error **errp)
>
> raw_probe_alignment(bs, s->fd, errp);
> bs->bl.min_mem_alignment = s->buf_align;
> - bs->bl.opt_mem_alignment = s->buf_align;
> + if (bs->bl.min_mem_alignment > bs->bl.opt_mem_alignment)
> + bs->bl.opt_mem_alignment = bs->bl.min_mem_alignment;
QEMU coding style uses {} even when the if statement body is only one
line.
pgpZt92p4XBv8.pgp
Description: PGP signature
- [Qemu-devel] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign, Denis V. Lunev, 2015/05/04
- [Qemu-devel] [PATCH 1/2] block: minimal bounce buffer alignment, Denis V. Lunev, 2015/05/04
- Re: [Qemu-devel] [Qemu-block] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign, Stefan Hajnoczi, 2015/05/11
- Re: [Qemu-devel] [Qemu-block] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign, Denis V. Lunev, 2015/05/11
- Re: [Qemu-devel] [Qemu-block] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign, Denis V. Lunev, 2015/05/11
- Re: [Qemu-devel] [Qemu-block] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign, Stefan Hajnoczi, 2015/05/12
- Re: [Qemu-devel] [Qemu-block] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign, Denis V. Lunev, 2015/05/12
- Re: [Qemu-devel] [Qemu-block] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign, Paolo Bonzini, 2015/05/12
- Re: [Qemu-devel] [Qemu-block] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign, Stefan Hajnoczi, 2015/05/13