Re: [Qemu-devel] [patch 0/3] ui/cocoa.m: Add Machine menu

[Peter Crosthwaite]

On Mon, May 11, 2015 at 3:08 PM, Programmingkid
<address@hidden> wrote:
> This patch series adds a machine menu to the Macintosh interface.
> Patch 1/3 adds the machine menu with pause and resume menu items.
> Patch 2/3 adds menu items for all devices that are available.
> Patch 3/3 adds Reset and Power Down menu items.
>

Hi,

Please try using git format-patch and send-email for all of the patch
mails as well as the cover letter. The cover letter is generated by
passing the --cover-letter switch to git format-patch. You then edit
0000-cover-letter file and send the cover letter with the rest of the
mails.

You can optionally use patches utility to test your series for
applicability. Currently:

address@hidden patches]$ patches list 'from:"Programmingkid"
status:broken'
Message-id: address@hidden
From: Programmingkid <address@hidden>
Date: 2015-05-11
   [3/3] ui/cocoa.m: Add Reset and Power Down menu items to Machine menu

Message-id: address@hidden
From: Programmingkid <address@hidden>
Date: 2015-05-11
   [2/3] ui/cocoa.m: Adds device menu items to Machine menu

Message-id: address@hidden
From: Programmingkid <address@hidden>
Date: 2015-05-11
   [1/3] ui/cocoa.m: adds Machine menu with pause and resume menu items

Message-id: address@hidden
From: Programmingkid <address@hidden>
Date: 2015-05-11
   [0/3] ui/cocoa.m: Add Machine menu

Which indicates that this series is broken for some reason. I think
it's because of your ad-hoc cover.

The mail id are gmail as well as usually for a git send-email they are
git-send-email-XXXXX. Did you paste the patches into a mail client
manually?

Using git send-email via gmail is fairly easy to setup.

Anyways, patches is available here:

https://github.com/aliguori/patches

The fetch command you want to use is:

./patches fetch http://vmsplice.net/~patches/patches.json

patches list 'from:"Programmingkid" not status:broken'

Should show the series once it's good. Note git may correct the
authorships based on your real name so do the search both ways to see
what's up.

I recently had mail problems of my own and found this helpful as a
final "did I get it right" sanity check).

Regards,
Peter