qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/9] qapi: Fix generators to report command line


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 5/9] qapi: Fix generators to report command line errors decently
Date: Thu, 14 May 2015 09:16:26 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 05/11/2015 01:24 AM, Markus Armbruster wrote:
> Report to stderr, prefix with the program name.  Also reject
> extra arguments.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  scripts/qapi.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 

> @@ -999,4 +999,8 @@ def parse_command_line(extra_options = "", 
> extra_long_options = []):
>          do_c = True
>          do_h = True
>  
> +    if len(args) != 0:
> +        print >>sys.stderr, "%s: too many arguments"% sys.argv[0]

Spacing on both sides of %?  Or even:

print >>sys.stderr, sys.argv[0] + ": too many arguments"

but trivial enough to keep R-b whatever you decide.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]